Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tests failing in --pass check mode #68290

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

petrochenkov
Copy link
Contributor

Warnings reported at codegen or linking time either have to be converted to errors (preferable), or the tests for them need to be marked with // ignore-pass (as a last resort).

ecd5852 turned them from errors to warnings, but that shouldn't be necessary because it's still clear from the .stderr output that the errors are lints and not hard-coded.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2020
@petrochenkov
Copy link
Contributor Author

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2020

These deny lints were made warnings specifically to test that we don't accidentally regress them to hard errors. We can't make them hard errors (I tried arguing for hard errors in RFC 1229, but now the RFC explicitly states that these are never to become hard errors)

@petrochenkov
Copy link
Contributor Author

If we accidentally regress them the output will still change, the

note: lint level defined here
  --> $DIR/array-literal-index-oob.rs:3:9

will disappear.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2020

Sure, I get that, but that's still very subtle and only true for the first lint trigger. The subsequent ones will only change from error: to error[0080]: or something like that.

@petrochenkov
Copy link
Contributor Author

Ok, if you think these tests must use warnings, I'll have to add // ignore-pass.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 20, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 20, 2020

📌 Commit 8fa8b81 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 20, 2020
Fix some tests failing in `--pass check` mode

Warnings reported at codegen or linking time either have to be converted to errors (preferable), or the tests for them need to be marked with `// ignore-pass` (as a last resort).

rust-lang@ecd5852 turned them from errors to warnings, but that shouldn't be necessary because it's still clear from the `.stderr` output that the errors are lints and not hard-coded.
bors added a commit that referenced this pull request Jan 20, 2020
Rollup of 8 pull requests

Successful merges:

 - #67734 (Remove appendix from Apache license)
 - #67795 (Cleanup formatting code)
 - #68290 (Fix some tests failing in `--pass check` mode)
 - #68297 ( Filter and test predicates using `normalize_and_test_predicates` for const-prop)
 - #68302 (Fix #[track_caller] and function pointers)
 - #68339 (Add `riscv64gc-unknown-linux-gnu` into target list in build-manifest)
 - #68381 (Added minor clarification to specification of GlobalAlloc::realloc.)
 - #68397 (rustdoc: Correct order of `async` and `unsafe` in `async unsafe fn`s)

Failed merges:

r? @ghost
@bors bors merged commit 8fa8b81 into rust-lang:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants